Skip to content

amartinez/CC-6859#12591

Merged
martinezjandrew merged 24 commits intomainfrom
amartinez/CC-6859
Feb 19, 2026
Merged

amartinez/CC-6859#12591
martinezjandrew merged 24 commits intomainfrom
amartinez/CC-6859

Conversation

@martinezjandrew
Copy link
Contributor

@martinezjandrew martinezjandrew commented Feb 17, 2026

Fixes #CC-6869.

Implemented logic within wrangler containers registries configure to check if a specified secret name is already in-use and offer to reuse that secret. Also added --skip-confirmation flag to the command to skip all interactive prompts.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Not a documented feature
image
Open with Devin

@martinezjandrew martinezjandrew requested review from a team as code owners February 17, 2026 22:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: 99c7d62

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Contributor

claude bot commented Feb 17, 2026

Claude finished @martinezjandrew's task —— View job


Changeset Review Results

⚠️ Issues found

Issue: The changeset description does not match the recommended format from .changeset/README.md

According to the guidelines:

  • TITLE: Should be a single sentence with an imperative description of the change
  • BODY: One or more paragraphs explaining the reason for the change and anything notable about the approach

The current changeset combines everything into one long sentence. It should be split into:

  1. A concise title describing what was added
  2. A body explaining the functionality

Suggested format:

---
"wrangler": patch
---

Add secret reuse detection and skip-confirmation flag to `wrangler containers registries configure`

When configuring a registry, the command now checks if the specified secret name is already in use and offers to reuse it. A new `--skip-confirmation` flag has been added to skip all interactive prompts, useful for CI/CD environments.

Validation against criteria:

  1. Version Type: patch is appropriate for this enhancement
  2. ⚠️ Changelog Quality: Needs restructuring into title + body format
  3. Markdown Headers: No problematic headers present
  4. Analytics: No analytics changes
  5. N/A Dependabot: Not a dependency update
  6. N/A Experimental features: Not an experimental feature

Bonus Cuteness Report:
This is Squiggles. He's a caterpillar with transparent skin showing his insides and doesn't understand personal space. Comes with built-in googly eyes and interpretive dance moves. 14/10 would protect at all costs.


Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 17, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12591

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12591

miniflare

npm i https://pkg.pr.new/miniflare@12591

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12591

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12591

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12591

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12591

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12591

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12591

wrangler

npm i https://pkg.pr.new/wrangler@12591

commit: 99c7d62

martinezjandrew and others added 2 commits February 18, 2026 14:45
Co-authored-by: Nikita Sharma <54369599+nikitassharma@users.noreply.github.com>
Co-authored-by: Nikita Sharma <54369599+nikitassharma@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 19, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

Co-authored-by: Nikita Sharma <54369599+nikitassharma@users.noreply.github.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@martinezjandrew martinezjandrew merged commit 6f6cd94 into main Feb 19, 2026
61 of 64 checks passed
@martinezjandrew martinezjandrew deleted the amartinez/CC-6859 branch February 19, 2026 21:31
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 19, 2026
dario-piotrowicz added a commit that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants