[wrangler] Add hostname and IP validation for VPC services - #12700
Merged
jamesopstad merged 3 commits intoMar 11, 2026
Conversation
🦋 Changeset detectedLatest commit: 71cb663 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
5 times, most recently
from
March 2, 2026 11:45
90745d1 to
bff4947
Compare
RiscadoA
marked this pull request as ready for review
March 2, 2026 11:48
RiscadoA
changed the title
emily-shen
reviewed
Mar 2, 2026
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
from
March 2, 2026 15:33
bff4947 to
d0372c2
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
from
March 2, 2026 17:51
d0372c2 to
c3ef35a
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
2 times, most recently
from
March 3, 2026 09:11
50f94a8 to
84f865f
Compare
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
from
March 9, 2026 08:57
36c50eb to
49f4ee3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
from
March 10, 2026 10:17
49f4ee3 to
5d7fca0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
RiscadoA
force-pushed
the
rantunes/vpc-hostname-validation
branch
from
March 10, 2026 10:23
5d7fca0 to
3865f64
Compare
jamesopstad
approved these changes
Mar 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes N/A (internal tracking).
Add hostname validation to
wrangler vpc service create/update. Previously any string was accepted as--hostnamewith no client-side checks.Also validates that the configured ipv4/ipv6 addresses are valid ip addresses using
net.Changes
validateHostname()invalidation.ts: rejects URL schemes, paths, ports, bare IPs (v4/v6), whitespace, total length >253validateRequest()— throwsUserErrorwith clear messagesvpc.test.ts(13 unit + 2 CLI integration)