Skip to content

CC-7209: Deprecate and hide OpenSSH options from ssh command - #12853

Merged
gpanders merged 1 commit into
mainfrom
ganders/CC-7209
Mar 11, 2026
Merged

CC-7209: Deprecate and hide OpenSSH options from ssh command#12853
gpanders merged 1 commit into
mainfrom
ganders/CC-7209

Conversation

@gpanders

@gpanders gpanders commented Mar 11, 2026

Copy link
Copy Markdown
Member

Fixes CC-7209.

Deprecate and hide OpenSSH-specific config flags for the wrangler containers ssh command.

Today we use OpenSSH to implement the SSH feature, but in the future we will not, at which point these flags will stop working. We are hiding and deprecating them now before the SSH feature is fully launched so that users do not come to depend on them.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation

Open with Devin

@gpanders
gpanders requested review from a team as code owners March 11, 2026 17:26
@changeset-bot

changeset-bot Bot commented Mar 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 541db34

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod

workers-devprod commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Let me review the changes systematically:

  1. Arg definitions refactored: The duplicated arg definitions (previously in both sshYargs and containersSshCommand) are now defined once in sshArgDefs and reused. This is a good deduplication.

  2. deprecated: true and hidden: true added to all OpenSSH-specific flags: This is well-established precedent in the codebase (38 existing uses). The deprecated field is explicitly supported in the ArgDefinition type.

  3. Removed old exports sshYargs and sshCommand: No other file imports these, so this is safe.

  4. Type change: Switched from StrictYargsOptionsToInterface<typeof sshYargs> to HandlerArgs<typeof sshArgDefs> - consistent with the createCommand pattern.

  5. Test cleanup: The MSW mock responses are improved from manually constructing new HttpResponse(JSON.stringify(...)) with wrong type: "applicaton/json" (typo) to using HttpResponse.json(...) properly. Good improvement.

  6. Changeset: minor version bump is correct for a deprecation.

Everything looks correct. No logic bugs, no security issues, no backward compatibility violations (the flags still work, they're just hidden and deprecated).

LGTM

github run

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Mar 11, 2026
@gpanders
gpanders merged commit ff543e3 into main Mar 11, 2026
47 of 56 checks passed
@gpanders
gpanders deleted the ganders/CC-7209 branch March 11, 2026 21:50
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants