Reduce @cloudflare/vitest-pool-workers log noise - #13007
Conversation
🦋 Changeset detectedLatest commit: 27cf551 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
d55253d to
c8de3be
Compare
|
Instead of adding a configurable logLevel option, I've updated this PR to take a simpler approach:
|
@cloudflare/vitest-pool-workers log noise
|
That's great! I wasn't sure if it was better to provide a configuration on userland or force a loglevel to a higher level! Both looks great to me but maybe some people would prefer to have something configurable? |
|
I'm also seeing info logs, which I'm not sure add a lot of value... I feel like, by default, I should only see warning/error logs in output. What do you think @sheplu? |
|
@mrmckeb When I did the PR I was not sure to which level should be the default, I did not want to move from debug to warn - but I would agree that the info logs are not that useful. The only information would be to now that it started properly, which trigger a lot of noise if you do have a lot of tests. So I think warn by default may be a good call! |
|
@penalosa any news regarding this PR? |
…kers Instead of adding a new config option, reduce the default log level from VERBOSE to WARN and move debug/info messages behind util.debuglog(). - Default log level is now WARN (only actionable messages print) - Debug output available via NODE_DEBUG=vitest-pool-workers - Promote 'Removing compat flag' to warn (overrides user's explicit config) - Remove logLevel schema field, setPoolLogLevel, and associated test
a311593 to
97bbf5a
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes #12014
Add a new parameter to allow logLevel threshold on the vitest-pool-workers allowing to hide debug messages like
vpw:debugI don't think the failling CI is due to the change I did
A picture of a cute animal (not mandatory, but encouraged)