fix(wrangler): skip versions deploy prompts for args - #13739
Conversation
🦋 Changeset detectedLatest commit: 77e9062 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
I've thoroughly reviewed the changes. Let me assess the overall quality: Logic: The core change is clean — when version specs are provided via CLI args (positional or Edge case consideration: The deployment message prompt at line 167 also uses Rename consistency: The Tests: Three new tests cover the main scenarios — positional version spec without Changeset: Properly formatted patch changeset with clear description. I don't see any logic bugs, security issues, backward compatibility problems, or incorrect API behavior. The change is straightforward and well-tested. LGTM |
emily-shen
left a comment
There was a problem hiding this comment.
can we add to the args description that
percentage:{
...
default: 100
...
},
"version-specs": {
describe:
"Shorthand notation to deploy Worker Version(s) [<version-id>@<percentage>..]. Percentage defaults to 100 if only the version-id is provided.",
|
Codeowners approval required for this PR:
Show detailed file reviewers |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
|
@emily-shen Updated the description in 9ab7a95 |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Fixes #5709.
A picture of a cute animal (not mandatory, but encouraged)