Skip to content

fix(vite-plugin-cloudflare): deny more credential files in vite dev server - #13814

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-vite-config-denylist
May 5, 2026
Merged

fix(vite-plugin-cloudflare): deny more credential files in vite dev server#13814
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-vite-config-denylist

Conversation

@edmundhung

@edmundhung edmundhung commented May 5, 2026

Copy link
Copy Markdown
Member

Fixes DEVX-2586


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 15b9c97

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 5, 2026
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team May 5, 2026 14:05
@workers-devprod

workers-devprod commented May 5, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@ask-bonk

ask-bonk Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

The code change is clean and correct:

  • The deny list properly expands *.{crt,pem} to *.{crt,pem,key,pfx,p12,p8,jks} -- all standard certificate/key store formats.
  • .npmrc, .yarnrc, and .yarnrc.yml are correctly added as exact-match entries since they can contain registry auth tokens.
  • Test fixtures and test cases are present for every new entry, covering both dev (403) and preview (worker response) paths.
  • The changeset is properly formatted as a patch.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented May 5, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13814

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13814

miniflare

npm i https://pkg.pr.new/miniflare@13814

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13814

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13814

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13814

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13814

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13814

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13814

wrangler

npm i https://pkg.pr.new/wrangler@13814

commit: 15b9c97

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@edmundhung
edmundhung merged commit a2f9c26 into main May 5, 2026
62 of 63 checks passed
@edmundhung
edmundhung deleted the edmundhung/fix-vite-config-denylist branch May 5, 2026 16:09
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants