Skip to content

[wrangler] Rename Workflows schedule property to schedules - #14044

Merged
pombosilva merged 1 commit into
mainfrom
osilva/workflows-rename-schedule-property
May 26, 2026
Merged

[wrangler] Rename Workflows schedule property to schedules#14044
pombosilva merged 1 commit into
mainfrom
osilva/workflows-rename-schedule-property

Conversation

@pombosilva

@pombosilva pombosilva commented May 25, 2026

Copy link
Copy Markdown
Contributor

Fixes WOR-1221.

Renames the schedule Workflow binding property (added in #13467) to schedules to match the control plane API.
The field is still non-functional - scheduled triggering of Workflow instances is not yet available.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the field is not yet documented externally and remains non-functional

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented May 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ed7948c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 25, 2026
@workers-devprod
workers-devprod requested review from a team and penalosa and removed request for a team May 25, 2026 19:15
@workers-devprod

workers-devprod commented May 25, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

@pombosilva Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented May 25, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14044

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14044

miniflare

npm i https://pkg.pr.new/miniflare@14044

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14044

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14044

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14044

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14044

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14044

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14044

wrangler

npm i https://pkg.pr.new/wrangler@14044

commit: ed7948c

@pombosilva

Copy link
Copy Markdown
Contributor Author

/bonk

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean rename from schedule to schedules. All references (types, validation, deploy triggers, miniflare bindings, tests, error messages, changeset) are updated consistently — no stale occurrences of the old property name remain.

LGTM.

@ask-bonk

ask-bonk Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Reviewed and approved PR #14044. The rename from schedule to schedules is straightforward and comprehensive — all type definitions, validation logic, deploy triggers, miniflare binding options, error messages, tests, and the changeset are consistently updated with no stale references left behind.

github run

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread .changeset/workflows-schedules-rename.md

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 26, 2026
@ask-bonk

ask-bonk Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

The prior PR also only listed wrangler: patch (well, minor) and didn't include workers-utils. This is consistent with the repo's conventions — workers-utils is released transitively.

This is a clean, mechanical rename. All types, validation, deploy logic, miniflare bindings, error messages, tests, and snapshot assertions are consistently updated. No stale references remain. The changeset follows existing conventions.

LGTM

github run

@pombosilva
pombosilva merged commit 8b1467e into main May 26, 2026
61 of 63 checks passed
@pombosilva
pombosilva deleted the osilva/workflows-rename-schedule-property branch May 26, 2026 10:17
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants