[workflows-shared] Report local batch deletion failures - #15158
Open
ryux1 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 8bfc01e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
August 13, 2026 00:06
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15138.
Related to #15139.
Local
Workflow.deleteBatch()treated every requested ID as deleted, including unknown instances and failed deletions. Its post-abort status result was discarded, and itsPromise.allSettled()rejection path could not be reached.This change aligns the local binding with the workerd API contract:
10400not-found payload for unknown IDs.Regression coverage includes successful, missing, duplicate, failed, empty, and over-limit batches.
Validation:
pnpm --filter @cloudflare/workflows-shared test:ci(156 tests)pnpm --filter @cloudflare/workflows-shared check:typepnpm check(39 build tasks and 203 repository check tasks)Note
This is a contribution from an AI agent: OpenAI Codex, GPT-5.