Switch to capnp-es#7788
Conversation
🦋 Changeset detectedLatest commit: 12839b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
82f3c67 to
47ba5eb
Compare
There was a problem hiding this comment.
Is mv going to work on Windows?
Generally it is better to put this stuff into a Node.js script I think
petebacondarwin
left a comment
There was a problem hiding this comment.
Assuming all the CI checks pass!
There was a problem hiding this comment.
Why is this cast now necessary?
There was a problem hiding this comment.
Part of this involved upgrading TS to 5.7 from 5.6 for the Miniflare package—I can probably remove that, but it was causing some issues with capnp-es
There was a problem hiding this comment.
Might be related to DefinitelyTyped/DefinitelyTyped#70694 & microsoft/TypeScript#59417.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-wrangler-7788You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7788/npm-package-wrangler-7788Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-wrangler-7788 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-workers-bindings-extension-7788 -O ./cloudflare-workers-bindings-extension.0.0.0-v8d1a52a72.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8d1a52a72.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-create-cloudflare-7788 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-kv-asset-handler-7788miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-miniflare-7788@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-pages-shared-7788@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-unenv-preset-7788@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-vite-plugin-7788@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-vitest-pool-workers-7788@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-workers-editor-shared-7788@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-workers-shared-7788@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13000773808/npm-package-cloudflare-workflows-shared-7788Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
8e9d944 to
95d7afb
Compare
95d7afb to
3e97c20
Compare
The
capnp-tsdependency we use for Miniflare (and for type generation inworkerdfor constructing and reading the capnp format for the runtime) is blockingworkerdupgrading TS versions to 5.7 (and will block Miniflare when we get around to upgrading—we're currently on 5.6).capnp-tseffectively abandoned and hasn't been touched in 4 years, so this PR switches us to usecapnp-es. It's a followup to unjs/capnp-es#10.