R2-3182: Remove wrangler Banner from R2 GetObject in Pipe Mode - #9800
Conversation
🦋 Changeset detectedLatest commit: 6a16744 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
7ae0759 to
ae602cd
Compare
|
@helloimalastair this will need a backport |
emily-shen
left a comment
There was a problem hiding this comment.
this behaviour has in fact regressed several times across various commands 🥲 - would you be able to add a test?
we mock out the banner in tests so you'll have to add vi.unmock("../wrangler-banner");
efd9e77 to
c74e797
Compare
c74e797 to
6a16744
Compare
|
Congratulations @helloimalastair, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmdg4a53j094607l415zenso8 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
backport in #10050 |
Fixes R2-3182.
When using the
--pipeflag forwrangler r2 object get, outputting thewranglerheader breaks the file that is created, since it isn't actually a part of the object content.