Skip to content

R2-3182: Remove wrangler Banner from R2 GetObject in Pipe Mode - #9800

Merged
emily-shen merged 2 commits into
cloudflare:mainfrom
helloimalastair:banner-r2-pipe
Jul 23, 2025
Merged

R2-3182: Remove wrangler Banner from R2 GetObject in Pipe Mode#9800
emily-shen merged 2 commits into
cloudflare:mainfrom
helloimalastair:banner-r2-pipe

Conversation

@helloimalastair

@helloimalastair helloimalastair commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Fixes R2-3182.

When using the --pipe flag for wrangler r2 object get, outputting the wrangler header breaks the file that is created, since it isn't actually a part of the object content.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No changes to what the user needs to do to use the command.
  • Wrangler V3 Backport

@helloimalastair
helloimalastair requested a review from a team as a code owner June 30, 2025 18:15
@changeset-bot

changeset-bot Bot commented Jun 30, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6a16744

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jun 30, 2025

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9800

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9800

miniflare

npm i https://pkg.pr.new/miniflare@9800

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9800

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9800

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9800

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9800

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9800

wrangler

npm i https://pkg.pr.new/wrangler@9800

commit: 6a16744

@penalosa

penalosa commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

@helloimalastair this will need a backport

@emily-shen emily-shen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this behaviour has in fact regressed several times across various commands 🥲 - would you be able to add a test?

we mock out the banner in tests so you'll have to add vi.unmock("../wrangler-banner");

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jul 23, 2025
@emily-shen emily-shen added ci:skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr labels Jul 23, 2025
@emily-shen
emily-shen merged commit 3d4f946 into cloudflare:main Jul 23, 2025
42 of 46 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 23, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jul 23, 2025
@holopin-bot

holopin-bot Bot commented Jul 23, 2025

Copy link
Copy Markdown

Congratulations @helloimalastair, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmdg4a53j094607l415zenso8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@emily-shen

Copy link
Copy Markdown
Contributor

backport in #10050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-pr-description-validation Skip validation of the required PR description format contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants