[wrangler] make sure that the ready-on message is printed after the local runtime is ready

[dario-piotrowicz]

Fixes https://jira.cfdata.org/browse/DEVX-1978

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: changes related to a non-v3 feature

[changeset-bot]

🦋 Changeset detected

Latest commit: cb375fc502291edd3904e7acc20751c8d3f36377

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9910

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9910

miniflare

npm i https://pkg.pr.new/miniflare@9910

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9910

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9910

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9910

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9910

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9910

wrangler

npm i https://pkg.pr.new/wrangler@9910

commit: 764ec1e

[emily-shen]

so if i understand correctly, now we wait for all runtime controllers to be ready or torn down before printing ready - this might be a proxy server, the one with the actual user worker, or remote. is that right?

[emily-shen]

why are there changes to a pages fixture?

[dario-piotrowicz]

The test below does the following:

• clears the output (clearOutput())
• renames a file
• makes sure that the output is (still) empty (expect(getOutput()).toBe(""))

Before ready on was being printed basically at the earlier time (as soon as the proxy controller is initialized), before the output gets cleared, but now the log is being printed asynchronously when all runtimes are ready, which actually happens after the output gets cleared (making the toBe("") assertion fail).
That's why now we need to wait for the ready on message to be there first (so that we can be sure that that won't appear in the output)

If you'd prefer a different change here please let me know 🙂

[dario-piotrowicz]

so if i understand correctly, now we wait for all runtime controllers to be ready or torn down before printing ready - this might be a proxy server, the one with the actual user worker, or remote. is that right?

Yes 🙂

[penalosa]

Looks great! Thanks for putting up with all my nitpicking here

[dario-piotrowicz]

Looks great! Thanks for putting up with all my nitpicking here

No problem, thanks a lot for correcting all my silly mistakes! 🙏