Skip to content
This repository was archived by the owner on Jan 14, 2026. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix console warnings
This PR fixes console warnings across the application by:

- moving `class` to `className`
- adding a `key` prop when looping through an array of items and outputting it to the DOM (see [the docs](https://reactjs.org/docs/lists-and-keys.html) for explanation on this)
- moving `stop-opacity` and `stop-color` to `stopOpacity` and `stopColor`, respectively

Closes #10
  • Loading branch information
kristianfreeman committed Nov 14, 2019
commit b23f94478d33fab4f31fbfe3ce999f3509481d91
68 changes: 34 additions & 34 deletions src/components/footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,51 +4,51 @@ import React from 'react'
import "../vendor/workers-brand-assets/css/components/footer.css"

const Footer = () => (
<footer class="Footer Footer-with-top-separator">
<div class="Footer--columns">
<div class="Footer--column Footer--column-logo">
<a href="https://workers.cloudflare.com" class="Footer--logo-link Link Link-without-underline">
<img class="Footer--logo-link-image" alt="Workers logo" src="https://workers.cloudflare.com/resources/logo/logo.svg"/>
<footer className="Footer Footer-with-top-separator">
<div className="Footer--columns">
<div className="Footer--column Footer--column-logo">
<a href="https://workers.cloudflare.com" className="Footer--logo-link Link Link-without-underline">
<img className="Footer--logo-link-image" alt="Workers logo" src="https://workers.cloudflare.com/resources/logo/logo.svg"/>
</a>
</div>
<div class="Footer--column">
<h2 class="Footer--column-title">Product</h2>
<ul class="Footer--column-list">
<li class="Footer--column-list-item"><a href="https://workers.cloudflare.com/sites" class="Link Link-without-underline Link-is-juicy">Workers Sites</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/storage/overview/" class="Link Link-without-underline Link-is-juicy">Key-value storage</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/using-cache/" class="Link Link-without-underline Link-is-juicy">Caching</a></li>
<li class="Footer--column-list-item"><a href="https://workers.cloudflare.com/#plans" class="Link Link-without-underline Link-is-juicy">Pricing</a></li>
<div className="Footer--column">
<h2 className="Footer--column-title">Product</h2>
<ul className="Footer--column-list">
<li className="Footer--column-list-item"><a href="https://workers.cloudflare.com/sites" className="Link Link-without-underline Link-is-juicy">Workers Sites</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/storage/overview/" className="Link Link-without-underline Link-is-juicy">Key-value storage</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/using-cache/" className="Link Link-without-underline Link-is-juicy">Caching</a></li>
<li className="Footer--column-list-item"><a href="https://workers.cloudflare.com/#plans" className="Link Link-without-underline Link-is-juicy">Pricing</a></li>
</ul>
</div>
<div class="Footer--column">
<h2 class="Footer--column-title">Docs</h2>
<ul class="Footer--column-list">
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/tutorials/" class="Link Link-without-underline Link-is-juicy">Tutorials</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/templates/" class="Link Link-without-underline Link-is-juicy">Templates</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/tooling/" class="Link Link-without-underline Link-is-juicy">Tooling reference</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/runtime/apis/" class="Link Link-without-underline Link-is-juicy">API reference</a></li>
<div className="Footer--column">
<h2 className="Footer--column-title">Docs</h2>
<ul className="Footer--column-list">
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/tutorials/" className="Link Link-without-underline Link-is-juicy">Tutorials</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/templates/" className="Link Link-without-underline Link-is-juicy">Templates</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/tooling/" className="Link Link-without-underline Link-is-juicy">Tooling reference</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/reference/runtime/apis/" className="Link Link-without-underline Link-is-juicy">API reference</a></li>
</ul>
</div>
<div class="Footer--column">
<h2 class="Footer--column-title">About</h2>
<ul class="Footer--column-list">
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/how-it-works/" class="Link Link-without-underline Link-is-juicy">How it works</a></li>
<li class="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/tips/" class="Link Link-without-underline Link-is-juicy">Tips</a></li>
<li class="Footer--column-list-item"><a href="https://blog.cloudflare.com/serverlist/" class="Link Link-without-underline Link-is-juicy">Newsletter</a></li>
<li class="Footer--column-list-item"><a href="https://blog.cloudflare.com/tag/serverless/" class="Link Link-without-underline Link-is-juicy">Blog</a></li>
<div className="Footer--column">
<h2 className="Footer--column-title">About</h2>
<ul className="Footer--column-list">
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/how-it-works/" className="Link Link-without-underline Link-is-juicy">How it works</a></li>
<li className="Footer--column-list-item"><a href="https://developers.cloudflare.com/workers/about/tips/" className="Link Link-without-underline Link-is-juicy">Tips</a></li>
<li className="Footer--column-list-item"><a href="https://blog.cloudflare.com/serverlist/" className="Link Link-without-underline Link-is-juicy">Newsletter</a></li>
<li className="Footer--column-list-item"><a href="https://blog.cloudflare.com/tag/serverless/" className="Link Link-without-underline Link-is-juicy">Blog</a></li>
</ul>
</div>
<div class="Footer--column">
<h2 class="Footer--column-title">Help</h2>
<ul class="Footer--column-list">
<li class="Footer--column-list-item"><a href="https://www.cloudflarestatus.com/" class="Link Link-without-underline Link-is-juicy">Status</a></li>
<li class="Footer--column-list-item"><a href="https://community.cloudflare.com/c/developers/workers" class="Link Link-without-underline Link-is-juicy">Forum</a></li>
<li class="Footer--column-list-item"><a href="https://support.cloudflare.com/hc/en-us/sections/360000215372-Cloudflare-Workers" class="Link Link-without-underline Link-is-juicy">Support</a></li>
<li class="Footer--column-list-item"><a href="https://twitter.com/CloudflareDev" class="Link Link-without-underline Link-is-juicy">Twitter</a></li>
<div className="Footer--column">
<h2 className="Footer--column-title">Help</h2>
<ul className="Footer--column-list">
<li className="Footer--column-list-item"><a href="https://www.cloudflarestatus.com/" className="Link Link-without-underline Link-is-juicy">Status</a></li>
<li className="Footer--column-list-item"><a href="https://community.cloudflare.com/c/developers/workers" className="Link Link-without-underline Link-is-juicy">Forum</a></li>
<li className="Footer--column-list-item"><a href="https://support.cloudflare.com/hc/en-us/sections/360000215372-Cloudflare-Workers" className="Link Link-without-underline Link-is-juicy">Support</a></li>
<li className="Footer--column-list-item"><a href="https://twitter.com/CloudflareDev" className="Link Link-without-underline Link-is-juicy">Twitter</a></li>
</ul>
</div>
</div>
<div class="Footer--legal">© 2019 Cloudflare, Inc. · <a class="Link Link-without-underline" href="https://www.cloudflare.com/privacypolicy/">Privacy</a> · <a class="Link Link-without-underline" href="https://www.cloudflare.com/website-terms/">Terms</a></div>
<div className="Footer--legal">© 2019 Cloudflare, Inc. · <a className="Link Link-without-underline" href="https://www.cloudflare.com/privacypolicy/">Privacy</a> · <a className="Link Link-without-underline" href="https://www.cloudflare.com/website-terms/">Terms</a></div>
</footer>
)

Expand Down
8 changes: 4 additions & 4 deletions src/components/header.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React from 'react'
import Nav from './nav'
import React from "react"
import Nav from "./nav"

// TODO - move these to workers-brand-assets and import into workers.cloudflare.com and built-with-workers
import '../vendor/workers.cloudflare.com/css/components/header.css'
import "../vendor/workers.cloudflare.com/css/components/header.css"

const Header = () => (
<header class="Header">
<header className="Header">
<Nav />
</header>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Layout = ({ children }) => {
return (
<>
<Header />
<main class="Main">{children}</main>
<main className="Main">{children}</main>
<Footer />
</>
)
Expand Down
Loading