Remove redundant be_symlink assertion

[rkoster]

Remove redundant be_symlink assertion in warden stemcell spec since be_linked_to already asserts the symlink target and ShelloutTypes::File does not implement #symlink?. This avoids calling a missing predicate and fixes CI failures.\n\nIf we prefer the more explicit assertion, we can instead implement ShelloutTypes::File#symlink? in a follow-up change.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rkoster / name: Ruben Koster (c912101)

[rkoster]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 433b3fa3-8691-4ce4-9f19-3a8a133afa68

📥 Commits

Reviewing files that changed from the base of the PR and between f959da4 and c912101.

📒 Files selected for processing (1)

• bosh-stemcell/spec/stemcells/warden_spec.rb

💤 Files with no reviewable changes (1)

• bosh-stemcell/spec/stemcells/warden_spec.rb

---

📝 Walkthrough

Walkthrough

A single assertion is removed from the systemd-binfmt.service specification in the Warden stemcell tests. The assertion checking that the service file is a symlink is deleted, while the existing check that it is linked to /dev/null is retained. This aligns with Apple Silicon Rosetta x86_64 emulation compatibility requirements.

Changes

Cohort / File(s)	Summary
Test Specification Update bosh-stemcell/spec/stemcells/warden_spec.rb	Removed symlink assertion from /etc/systemd/system/systemd-binfmt.service spec while preserving the link target validation for /dev/null.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A symlink check we needn't keep,
For Apple Silicon runs deep,
Rosetta flows where emulation thrives,
One assertion gone, the spec survives!
/dev/null still linked, our service thrives. 🍎✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing a redundant be_symlink assertion from the warden stemcell spec.
Description check	✅ Passed	The description is directly related to the changeset, explaining why the be_symlink assertion is redundant and why it causes CI failures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/remove-be_symlink

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[aramprice]

Thanks!