Track newly added CIS test cases in cis_spec.rb whitelist - #709
Merged
Alphasite merged 1 commit intoAug 11, 2026
Merged
Conversation
Add CIS-5.1.18, CIS-5.2.2, CIS-5.2.3, and CIS-5.4.3.2 to base_cis_test_cases in cis_spec.rb. These test cases were added in PR cloudfoundry#702 to verify sshd MaxStartups, sudo use_pty, sudo logfile, and shell TMOUT hardening, but were missing from the expected CIS test tracking list, causing CI failures in cis_spec.rb verification. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe base CIS test case list now includes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Alphasite
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #702 added CIS hardening assertions for SSH
MaxStartups(CIS-5.1.18), sudouse_pty(CIS-5.2.2), sudologfile(CIS-5.2.3), and shellTMOUT(CIS-5.4.3.2).These test descriptions were annotated with
(CIS-...)tags, which are dynamically tracked into$cis_test_casesbyspec/support/cis.rbduring spec execution. However,base_cis_test_casesinspec/stemcells/cis_spec.rbwas not updated to include these 4 new test cases, causing CI pipeline verification failures across IAAS builds onubuntu-jammy.This PR updates
base_cis_test_casesincis_spec.rbto include all 4 missing CIS rule IDs.