Skip to content

Track newly added CIS test cases in cis_spec.rb whitelist - #709

Merged
Alphasite merged 1 commit into
cloudfoundry:ubuntu-jammyfrom
karthickaliappa:fix-cis-spec-test-cases-tracking
Aug 11, 2026
Merged

Track newly added CIS test cases in cis_spec.rb whitelist#709
Alphasite merged 1 commit into
cloudfoundry:ubuntu-jammyfrom
karthickaliappa:fix-cis-spec-test-cases-tracking

Conversation

@karthickaliappa

Copy link
Copy Markdown
Contributor

Summary

PR #702 added CIS hardening assertions for SSH MaxStartups (CIS-5.1.18), sudo use_pty (CIS-5.2.2), sudo logfile (CIS-5.2.3), and shell TMOUT (CIS-5.4.3.2).

These test descriptions were annotated with (CIS-...) tags, which are dynamically tracked into $cis_test_cases by spec/support/cis.rb during spec execution. However, base_cis_test_cases in spec/stemcells/cis_spec.rb was not updated to include these 4 new test cases, causing CI pipeline verification failures across IAAS builds on ubuntu-jammy.

This PR updates base_cis_test_cases in cis_spec.rb to include all 4 missing CIS rule IDs.

Add CIS-5.1.18, CIS-5.2.2, CIS-5.2.3, and CIS-5.4.3.2 to base_cis_test_cases in cis_spec.rb. These test cases were added in PR cloudfoundry#702 to verify sshd MaxStartups, sudo use_pty, sudo logfile, and shell TMOUT hardening, but were missing from the expected CIS test tracking list, causing CI failures in cis_spec.rb verification.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2fcec5d4-f596-4435-81a3-a20871076a1d

📥 Commits

Reviewing files that changed from the base of the PR and between ffc5fb1 and c00b4ad.

📒 Files selected for processing (1)
  • bosh-stemcell/spec/stemcells/cis_spec.rb

Walkthrough

The base CIS test case list now includes CIS-5.1.18, CIS-5.2.2, CIS-5.2.3, and CIS-5.4.3.2. Existing entries remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding newly introduced CIS test cases to the whitelist.
Description check ✅ Passed The description explains the cause, affected branch, four added CIS IDs, and the CI failure resolved by the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Alphasite
Alphasite merged commit 34bf65e into cloudfoundry:ubuntu-jammy Aug 11, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants