Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174405456 The labels on this github issue will be updated when the story is started. |
mrosecrance
requested changes
Aug 19, 2020
src/bpm/runc/lifecycle/lifecycle.go
Outdated
|
|
||
| func newProcessFromContainerState(id, status string, pid int) *models.Process { | ||
| func newProcessFromContainerState(id string, status specs.ContainerState, pid int) *models.Process { | ||
| if status == ContainerStateStopped { |
Contributor
There was a problem hiding this comment.
Should be safe to remove
rkoster
force-pushed
the
update-to-runc-rc92
branch
from
9d4dd20 to
a868028
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: https://www.pivotaltracker.com/story/show/174389607
Ci will break until runc is also bumped in our ci image (currently pinned in concourse).