Randomize errand job name during tests to avoid cgroup conflicts#179
Merged
Randomize errand job name during tests to avoid cgroup conflicts#179
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
rajathagasthya
force-pushed
the
fix-runc-cgroup-conflict
branch
from
959b2bb to
9ca3393
Compare
aramprice
reviewed
Apr 23, 2025
Tests in the integration2 package use the same `errand` job name when executing `bpm run`. When these tests are run in quick succession, it causes a race between cgroups from the previous test (with the same name) being cleaned up after `bpm run` is complete and the currently executing test. When `runc` tries to create a new container, it finds a cgroup with the same name (errand) already exists and has processes inside it, so it errors with a `runc run failed: container's cgroup is not empty: 2 process(es) found` message. This change adds a random string to the errand job's name, so cgroups do not conflict with each other. Signed-off-by: Nishad Mathur <nishad.mathur@broadcom.com>
rajathagasthya
force-pushed
the
fix-runc-cgroup-conflict
branch
from
9ca3393 to
d6c875d
Compare
aramprice
approved these changes
Apr 23, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in the integration2 package use the same
errandjob name when executingbpm run. When these tests are run in quick succession, it causes a race between cgroups from the previous test (with the same name) being cleaned up afterbpm runis complete and the currently executing test. Whenrunctries to create a new container, it finds a cgroup with the same name (errand) already exists and has processes inside it, so it errors with arunc run failed: container's cgroup is not empty: 2 process(es) foundmessage.This change adds a random string to the errand job's name, so cgroups do not conflict with each other.