Skip to content

Rewrite hanging test in Ginkgo v2 style#193

Merged
ystros merged 1 commit intomasterfrom
fix-test-hang
Nov 13, 2025
Merged

Rewrite hanging test in Ginkgo v2 style#193
ystros merged 1 commit intomasterfrom
fix-test-hang

Conversation

@ystros
Copy link
Copy Markdown
Contributor

@ystros ystros commented Nov 13, 2025

The logs -f test was periodically hanging in CI. The likely reason appears to be that the test is not written in the async style expected by Ginkgo v2. In particular, the <-session.Exited would hang.

The `logs -f` test was periodically hanging in CI. The likely reason appears to
be that the test is not written in the async style expected by Ginkgo v2. In
particular, the `<-session.Exited` would hang.
@ystros
Copy link
Copy Markdown
Contributor Author

ystros commented Nov 13, 2025

I've let Ginkgo run the integration suite with --until-it-fails and it hasn't hung after 80 tries. Not a sure sign that this fixes the problem, but fairly good evidence that 1) this was a test-only problem and 2) we should probably switch over other tests as well.

@ystros ystros merged commit c64c677 into master Nov 13, 2025
3 checks passed
@ystros ystros deleted the fix-test-hang branch November 13, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants