Skip to content

Fix unintentional overwrite of BROKER_START_TIMEOUT#48

Merged
crhino merged 1 commit intocloudfoundry:masterfrom
nttlabs:fix-unintentional-overwrite-of-BROKER_START_TIMEOUT
Feb 27, 2015
Merged

Fix unintentional overwrite of BROKER_START_TIMEOUT#48
crhino merged 1 commit intocloudfoundry:masterfrom
nttlabs:fix-unintentional-overwrite-of-BROKER_START_TIMEOUT

Conversation

@nota-ja
Copy link
Contributor

@nota-ja nota-ja commented Feb 27, 2015

When the CATs config file (eg. integration_config.json)

  • have cf_push_timeout and
  • does not have broker_start_timeout

BROKER_START_TIMEOUT will be set to ZERO.
This seems an unintentional behavior.

When the CATs config file (eg. integration_config.json)

- have `cf_push_timeout` and
- does not have `broker_start_timeout`

`BROKER_START_TIMEOUT` will be set to _ZERO_.
This seems an unintentional behavior.
@cfdreddbot
Copy link

Hey nota-ja!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/89257584.

@crhino crhino merged commit e097be3 into cloudfoundry:master Feb 27, 2015
@crhino
Copy link
Contributor

crhino commented Feb 27, 2015

Thanks for the catch, @nota-ja!

@zaksoup & @crhino, CF Runtime Team

@nota-ja
Copy link
Contributor Author

nota-ja commented Feb 28, 2015

Thanks for merging, @zaksoup & @crhino !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants