Replace netaddr gem with stdlib IPAddr - #5330
Open
johha wants to merge 1 commit into
Open
Conversation
johha
force-pushed
the
replace-netaddr-with-ipaddr
branch
from
August 3, 2026 10:19
44010c0 to
27636b0
Compare
kathap
reviewed
Aug 3, 2026
The netaddr gem is effectively unmaintained (no releases despite open requests). Security group rule validation only needs parsing, family detection, and range-endpoint ordering, all of which IPAddr covers. This also aligns validation with downstream enforcement. netaddr accepted zero-padded IPv4 octets (e.g. 010.0.0.53, or ::ffff:010.0.0.1) that Diego rejects at enforcement time via Go's net.ParseIP, so such rules passed CC but never applied. IPAddr rejects them, surfacing the error to the operator at creation instead of failing silently later. The v3 message validator already rejected leading zeros; this brings the v2 path into line. Zero-padded IPv6 hextets remain valid (RFC 4291), unchanged. Range endpoints must be plain addresses, so a prefix is rejected there. Add a rule_validator spec covering the v2 validate_destination path (IPv4 leading-zero rejection, IPv6 padding, IPv4-mapped addresses), which previously had no dedicated coverage, and fix pre-existing test fixtures that relied on netaddr accepting malformed addresses (a trailing-dot range endpoint and a zero-padded octet).
johha
force-pushed
the
replace-netaddr-with-ipaddr
branch
from
August 5, 2026 08:22
27636b0 to
4158efc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The netaddr gem is effectively unmaintained (no releases despite open requests). Security group rule validation only needs parsing, family detection, and range-endpoint ordering, all of which IPAddr covers.
Behaviour is preserved:
Add a rule_validator spec covering the v2 validate_destination path, which previously had no dedicated coverage.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests