Implement bare-bones GET /v3/service_instances - #972
Merged
matt-royal merged 11 commits intoNov 13, 2017
Merged
Conversation
|
Hey deniseyu! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/152481619 The labels on this github issue will be updated when the story is started. |
[#152035378] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#152035378] Signed-off-by: Alex Blease <ablease@pivotal.io>
/v2/spaces/:guid/services endpoint now includes service instances that have been shared into the given space. [#152035378] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
* The only visible change is that the global auditor role now receives "true" for read when calling /v2/service_instances/:guid/permissions. This tells the service broker that the user is allowed to view the service instance dashboard. They already have read access to the service instance, so we don't anticipate that this is a problem. [#152035378] Signed-off-by: Derik Evangelista <devangelista@pivotal.io>
… spaces * Also cleaned up some of the null checking in service_instance_acess and added tests for access permissions on shared service instances. [#152035378] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#152035378] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#152631507] Signed-off-by: Denise Yu <dyu@pivotal.io>
* List all service instances that a user has permission to see [#152073155] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
[#152073155] Signed-off-by: Alex Blease <ablease@pivotal.io>
This change allows developers who have been granted access to a service instance through service instance sharing, to query that service instance via /v3/service_instances. [#152344116] Signed-off-by: Alex Blease <ablease@pivotal.io>
[#152344116] Signed-off-by: Jen Spinney <jennifer.spinney@suse.com>
deniseyu
force-pushed
the
pr-service-instance-sharing-v3-service-instances
branch
2 times, most recently
from
November 7, 2017 14:43
03bfd63 to
d471142
Compare
4 tasks
cf-gitbot
added
delivered
in progress
and removed
unscheduled
delivered
in progress
labels
deniseyu
deleted the
pr-service-instance-sharing-v3-service-instances
branch
November 28, 2017 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an app dev, I can list shared service instances using the v3 API. #152344116
NOTE: This PR builds on top of #961, which should be merged first. The actual changes on top of #961 can be viewed in this diff.
What
This PR adds limited support for GET /v3/service_instances list endpoint. This is required by the service instance sharing track to enable the CLI to resolve service instances names to guids in v3. At the moment it returns only managed service instances, and each record returned only contains
name,guid,created_atandupdated_at.It would be pretty easy for us to return user-provided service instances in this endpoint, but it is not strictly required by the scope of the service instance sharing epic. If you'd like us to modify this endpoint to additionally support user-provided services, please let us know.
Changes:
PR
masterbranchbundle exec rakeThanks, sapi (@jenspinney and @deniseyu)