Sharees get 403 instead of 404 when sharing a share - #984
Merged
elenasharma merged 7 commits intoNov 16, 2017
Conversation
|
Hey deniseyu! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/152721175 The labels on this github issue will be updated when the story is started. |
4 tasks
ablease
force-pushed
the
pr-service-instance-sharing-sharee-sharing-a-share
branch
from
November 14, 2017 10:33
dc05963 to
becba4a
Compare
* The broker can return a shareable field as part of the service metadata response to /v2/catalog. [#152540454] Signed-off-by: Sam Gunaratne <sgunaratne@pivotal.io>
[#151909779]
… instance * This behaviour already existed, this commit just adds additional tests [#150973376] Signed-off-by: Denise Yu <dyu@pivotal.io>
* Only developers who have write access to the service instance can perform an update. [#150973390] Signed-off-by: Derik Evangelista <devangelista@pivotal.io>
or unshare [#151441010] Signed-off-by: Denise Yu <dyu@pivotal.io>
deniseyu
force-pushed
the
pr-service-instance-sharing-sharee-sharing-a-share
branch
from
November 16, 2017 16:43
becba4a to
9325544
Compare
deniseyu
deleted the
pr-service-instance-sharing-sharee-sharing-a-share
branch
November 28, 2017 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an app dev (receiver), I cannot share a service instance that has been shared with me where I do not have access to the service instance. #151441010
NOTE: This PR builds on top of #983, which should be merged first. The actual changes on top of #983 can be viewed in this diff.
What
Previously, a developer in a space that received a shared service instance could not attempt to share that instance to further spaces. This resulted in a 404. This PR changes the error code to be 403 Not Authorized. Users who lack read access to the source space, but have access to one of the spaces to which the service instance is shared will experience this change. All others that lack read access will continue to receive 404.
PR
masterbranchbundle exec rakeThanks, sapi (@jenspinney and @deniseyu)