Skip to content

Upgrade Container metric#10

Closed
antechrestos wants to merge 1 commit intocloudfoundry:masterfrom
antechrestos:patch-1
Closed

Upgrade Container metric#10
antechrestos wants to merge 1 commit intocloudfoundry:masterfrom
antechrestos:patch-1

Conversation

@antechrestos
Copy link
Copy Markdown

@antechrestos antechrestos commented Mar 18, 2020

Following the diego client implementation, I added the following attributes to ContainerMetric

  • absoluteCPUUsage
  • absoluteCPUEntitlement
  • absoluteCPUEntitlement

@cf-gitbot
Copy link
Copy Markdown

cf-gitbot commented Mar 18, 2020

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 18, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@antechrestos
Upgrade Container metric
7465cc2 
Added the following attributes to ContainerMetric

* absoluteCPUUsage
* absoluteCPUEntitlement
* absoluteCPUEntitlement
@antechrestos
Copy link
Copy Markdown
Author

antechrestos commented Mar 18, 2020

@bradylove I don't know if this project is still alive. I've just spotted ContainerMetric missed some attributes

@antechrestos antechrestos mentioned this pull request Mar 18, 2020
Open
@pianohacker
Copy link
Copy Markdown

pianohacker commented Mar 18, 2020

We're currently looking to deprecate this protocol in favor of the v2 envelope format (and, if suitable, access to logs and metrics via syslog/Prometheus endpoints). Could you tell me more about your use case?

@antechrestos
Copy link
Copy Markdown
Author

antechrestos commented Mar 19, 2020 •
edited
Loading

@pianohacker Thank you for your quick reply.
I currently work on the [python api client library](https://github.com/cloudfoundry-community/cf-python-client] and had this need .
Instead of upgrading the proto file on my side, I ended on your repo.

Shall I directly use the v2 enveloppe proto to decode log message instead?

@MasslessParticle
Copy link
Copy Markdown

MasslessParticle commented Apr 8, 2020 •
edited
Loading

It would be better to use the v2 envelopes, for sure. As @pianohacker mentioned, the v1 API is deprecated and we're avoiding making changes to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antechrestos @cf-gitbot @pianohacker @MasslessParticle