Merged
Conversation
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
ctlong
commented
Feb 12, 2022
Member
|
@ctlong it sounds like you're not ready for this one to be merged. Do you want to put it back in draft mode or resolve your comments? |
ctlong
force-pushed
the
feat/protobuf-syntax
branch
from
a8a247f to
b528606
Compare
* Reformat comments * Add reserved fields * Remove unused uuid.proto import in metric.proto
ctlong
force-pushed
the
feat/protobuf-syntax
branch
from
b528606 to
0a60341
Compare
ctlong
added a commit
to ctlong/loggregator-v1-protobuf-example
that referenced
this pull request
Jun 17, 2022
Generated from the code in cloudfoundry/dropsonde-protocol#11.
Member
Author
|
This is the first step toward resolving cloudfoundry/go-loggregator#62. |
This doesn't really matter since we don't store it in this repo, the only thing that really matters is that the package is called `events`. However, since we will pretty much always put this go code into sonde-go, we should use that package name for clarity.
The files can't be generated relative to the `events` dir, or else `events` isn't included in the absolute path of the generated protobuf files. This can easily cause conflicts with other repos that define similarly named protobuf definitions (i.e. loggregator v2).
ctlong
force-pushed
the
feat/protobuf-syntax
branch
from
59d696d to
439c6e7
Compare
ctlong
added a commit
to ctlong/loggregator-v1-protobuf-example
that referenced
this pull request
Jun 27, 2022
Generated from the code in cloudfoundry/dropsonde-protocol#11. This changes the source to include the `events` package, which will help resolve some namespace conflicts.
Signed-off-by: Ben Fuller <benjaminf@vmware.com> Co-authored-by: Ben Fuller <benjaminf@vmware.com>
Signed-off-by: Ben Fuller <benjaminf@vmware.com> Co-authored-by: Ben Fuller <benjaminf@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto2syntax definitionsgo_packageoption for generating go files//instead of///, keep within 80 lines)UseCAPITALS_WITH_UNDERSCORESfor enumsUseunderscore_separated_namesfor field names