Skip to content

generate-go.sh script removes auto-generated init functions#3

Closed
Amit-PivotalLabs wants to merge 1 commit intocloudfoundry:masterfrom
Amit-PivotalLabs:master
Closed

generate-go.sh script removes auto-generated init functions#3
Amit-PivotalLabs wants to merge 1 commit intocloudfoundry:masterfrom
Amit-PivotalLabs:master

Conversation

@Amit-PivotalLabs
Copy link
Copy Markdown

No description provided.

@cf-gitbot
Copy link
Copy Markdown

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/95480376.

@roxtar
Copy link
Copy Markdown
Contributor

roxtar commented May 29, 2015

The RegisterEnum calls are required for proto.MarshalText and proto.UnmarshalText functions to work correctly. The text marshaling methods are used to convert protobuf messages to strings and this change would break that. We are rejecting this PR due to that.

To support your use-case of using noaa and dropsonde in the same project, we have created another story to separate out the generated go files into their own library.

@roxtar roxtar closed this May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants