Add id field to envelope#4
Closed
achawki wants to merge 1 commit intocloudfoundry:masterfrom
achawki:id-field
Closed
Add id field to envelope#4achawki wants to merge 1 commit intocloudfoundry:masterfrom achawki:id-field
achawki wants to merge 1 commit intocloudfoundry:masterfrom
achawki:id-field
Conversation
Signed-off-by: Philipp Thun <philipp.thun@sap.com>
|
Hey achawki! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/119516813 The labels on this github issue will be updated when the story is started. |
Author
|
Closing this PR for now since index field is used for spec.id with cloudfoundry/loggregator@bbe02f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
idfield to envelope. We want to correlate metrics from BOSH with metrics emitted by the metron agent. As BOSH metrics already contain the job instance id (https://bosh.io/docs/jobs.html#properties-spec,spec.id), we need to enhance the metron agent to include this field as well. Therefore - as a first step - we have added this new field to the dropsonde envelope.