Skip to content

Ignore G110 for app asset decompression as it's bounded by container FS quota #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcPaquette merged 1 commit into from
Sep 16, 2024
Merged

Ignore G110 for app asset decompression as it's bounded by container FS quota #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions depot/steps/upload_step.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ func (step *uploadStep) Run(signals <-chan os.Signal, ready chan<- struct{}) (er
os.Remove(finalFileLocation)
}()

// #nosec - G110 - We're fine with unbounded file decompression here as we have container filesystem quotas that will prevent this from eating up the entire diego cell disk space
_, err = io.Copy(tempFile, tarStream)
if err != nil {
step.logger.Error("failed-to-copy-stream", err)
Expand Down