Envoy proxy liveness checks#110
Merged
PlamenDoychev merged 1 commit intocloudfoundry:mainfrom Mar 21, 2025
Merged
Conversation
This was referenced Jan 28, 2025
Viktor-Velkov
force-pushed
the
envoy-liveness-checks
branch
from
d818ad3 to
1825198
Compare
mariash
requested changes
Mar 13, 2025
Member
mariash
left a comment
mariash
left a comment
There was a problem hiding this comment.
Looks good overall, just the test name mistype
| }) | ||
|
|
||
| Context("and proxy liveness check is disabled", func() { | ||
| It("starts the proxy liveness check", func() { |
Member
|
Oh and please change the commit message |
Viktor-Velkov
force-pushed
the
envoy-liveness-checks
branch
from
1825198 to
d8485b0
Compare
PlamenDoychev
approved these changes
Mar 21, 2025
Contributor
PlamenDoychev
left a comment
PlamenDoychev
left a comment
There was a problem hiding this comment.
Looks finally good to me. Feedback is already applied
Contributor
|
Merging the PR as, the feedback is already addressed. |
github-project-automation
bot
moved this from Inbox
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backward Compatibility
Breaking Change? No