Do not read entire file in memory for hash calculation#122
Merged
geofffranks merged 2 commits intocloudfoundry:mainfrom Jun 19, 2025
Merged
Conversation
Co-authored-by: Jan von Loewenstein <jan.von.loewenstein@sap.com>
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Contributor
|
Hi @pbusko , Can you also create one issue here: https://github.com/cloudfoundry/diego-release/issues and provide details and motivation for the proposal and link this PR to it. Just look at the various issues we have open and follow the "template". |
1 task
PlamenDoychev
approved these changes
Jun 18, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
geofffranks
approved these changes
Jun 19, 2025
Contributor
|
LGTM. I wanted to double check that |
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the uploader reads entire file in memory just for MD5 and SHA256 sums calculation. If a buildpack cache archive or droplets are large, it might affect the entire cell.
With the new approach the file is read with the default chunk sizes of 32K, not storing the actual content.
Backward Compatibility
Breaking Change? No