Skip to content

Increase envoy key size to 3072 bits #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ameowlia merged 1 commit into from
Dec 1, 2025
Merged

Increase envoy key size to 3072 bits #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion depot/containerstore/credmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const (
C2CCredCreationSucceededCount = "C2CCredCreationSucceededCount"
C2CCredCreationSucceededDuration = "C2CCredCreationSucceededDuration"
C2CCredCreationFailedCount = "C2CCredCreationFailedCount"
RSAPrivateKeySize = 3072
)

type Credentials struct {
Expand Down Expand Up @@ -351,7 +352,7 @@ func (c *credManager) generateC2cCred(logger lager.Logger, container executor.Co

func (c *credManager) generateCredForSAN(logger lager.Logger, certSAN certificateSAN, certGUID string) (Credential, error) {
logger.Debug("generating-private-key")
privateKey, err := rsa.GenerateKey(c.entropyReader, 2048)
privateKey, err := rsa.GenerateKey(c.entropyReader, RSAPrivateKeySize)
if err != nil {
return Credential{}, err
}
Expand Down
5 changes: 5 additions & 0 deletions depot/containerstore/credmanager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,11 @@ var _ = Describe("CredManager", func() {
Expect(cert.ExtKeyUsage).To(ContainElement(x509.ExtKeyUsageServerAuth))
Expect(cert.KeyUsage).To(Equal(x509.KeyUsageDigitalSignature | x509.KeyUsageKeyEncipherment | x509.KeyUsageKeyAgreement))

By("has the expected key length")
rsaKey, ok := cert.PublicKey.(*rsa.PublicKey)
Expect(ok).To(BeTrue(), "expected RSA public key")
Expect(rsaKey.N.BitLen()).To(Equal(containerstore.RSAPrivateKeySize))

By("signed by the rep intermediate CA")
CaCertPool := x509.NewCertPool()
CaCertPool.AddCert(CaCert)
Expand Down