Resolves deadlock issue with the readiness check.#127
Merged
winkingturtle-vmw merged 1 commit intomainfrom Jan 15, 2026
Merged
Conversation
A deadlock occurs when the storenode.run() function exits due to startup health check execution timing out, while the readiness check has already succeeded, placing a state transition into the readiness channel that will never be read. As a result, the readiness check was never processing signals to exit, resulting in stale containers. This resolves this, and also resolves a hypothetical deadlock if the readiness channel is unable to be read from when transitioning from ready to not-ready.
1 task
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
winkingturtle-vmw
approved these changes
Jan 15, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deadlock occurs when the storenode.run() function exits due to startup health check execution timing out, while the readiness check has already succeeded, placing a state transition into the readiness channel that will never be read. As a result, the readiness check was never processing signals to exit, resulting in stale containers.
This resolves this, and also resolves a hypothetical deadlock if the readiness channel is unable to be read from when transitioning from ready to not-ready.
Summary
no
Backward Compatibility
Breaking Change? no