Get rid of go bindata - #419
Merged
Merged
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
jorbaum
force-pushed
the
get-rid-of-go-bindata
branch
from
February 24, 2026 14:28
d6953b9 to
d74e1a3
Compare
jorbaum
commented
Feb 25, 2026
| // NewEgressTLSConfig provides a convenient means for creating a *tls.Config | ||
| // which uses the CA, cert, and key for the egress endpoint. | ||
| func NewEgressTLSConfig(caPath, certPath, keyPath string) (*tls.Config, error) { | ||
| return newTLSConfig(caPath, certPath, keyPath, "reverselogproxy") |
Contributor
Author
There was a problem hiding this comment.
This needed to change to reverselogproxy from metron, as the server cert in generate-test-certs below actually used metron as common-name while client cert used reverselogproxy as common name.
Before this change the wrong common names were used in the certificates.
jorbaum
force-pushed
the
get-rid-of-go-bindata
branch
from
March 3, 2026 15:19
0976db7 to
8d4be86
Compare
chombium
requested changes
Mar 5, 2026
chombium
left a comment
chombium
left a comment
Contributor
There was a problem hiding this comment.
Please remove empty code blocks
Contributor
Author
Did so. |
chombium
approved these changes
Mar 5, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #79 .
Replaces go-bindata with cloudfoundry/tlsconfig just like it is done in loggregator-agent-release. Also removes the
generate-test-certsscript as scripts are no longer needed.I also updated the dependencies as some were outdated after adding cloudfoundry/tlsconfig.