Don't use lsb_release to find platform - #1004
Merged
Merged
Conversation
Contributor
|
hello @ryanmoran - doesn't your change mean that if the underlying platform is neither Actually, is that an issue? I'm asking cause I got bit by this change while running the tests in a container based on |
Contributor
Author
|
Yes. I think the open question here is whether or not the buildpack needs to support these other OSes given that we basically only ship Ubuntu through the |
Contributor
|
yeah, fair enough, That makes sense, thanks. |
ramonskie
pushed a commit
that referenced
this pull request
Dec 4, 2025
Don't use lsb_release to find platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.