Conversation
ryanmoran
force-pushed
the
byo-ruby
branch
5 times, most recently
from
March 9, 2023 20:25
baa514b to
32d832c
Compare
- the bin/{compile,detect,finalize,release} executables have been
wrapped in a small shim that makes sure a Ruby interpreter is
available on the PATH before exec-ing the existing buildpack
entrypoints
- works both online and offline
- currently pinned to the latest Ruby 3.1.x version available in the
Ruby Buildpack repository
Contributor
Author
|
As I was merging a number of other PRs, the tab I had open with this PR got mixed in the shuffle and I accidentally pushed the big green button without thinking. I have already reverted the commit on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the
cflinuxfs4stack becomes the default in CF, we will be removing therubyinterpreter from the set of installed packages. This means that the Java buildpack will need to bring its own interpreter in order to keep running on Ruby.This PR contains a small
bashshim that sits in front of each of the buildpackbin/*executables. The shim makes sure that there is an installed Ruby interpreter in a predefined location and thenexecs the equivalent Ruby entrypoint for the buildpack.The buildpack packaging and configuration have been slightly modified to allow for this to work both online and offline.
The buildpack will run with the latest Ruby 3.1.x version available in the Ruby Buildpack repository.