Move to golangci v2 - #704
Merged
Merged
Conversation
|
|
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
jorbaum
marked this pull request as ready for review
August 11, 2025 14:13
jorbaum
commented
Aug 12, 2025
Contributor
|
@jorbaum Can you please rebase the master in your branch and re-run the linting tests? |
Contributor
Author
Done. Linting tests look fine after rebase. |
Also fixes issues reported by golangci-lint v2: * Change `Replace` to `ReplaceAll` where sensible * Omit an embedded field * `ingress/v2` had been imported twice * Nicer casing in logs Noteworthy changes in golangci-lint v2: * New config format (migrated with `migrate` command) * Default timeout is now 0 instead of 1 minute.
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move to golangci-lint v2.
Changes:
ReplacetoReplaceAllwhere sensiblecode.cloudfoundry.org/loggregator-agent-release/src/pkg/ingress/v2had been imported twiceNoteworthy changes in golangci-lint v2:
migratecommand)Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch