Skip to content

Add AppArmor custom rules - #237

Closed
jorbaum wants to merge 2 commits into
cloudfoundry:mainfrom
jorbaum:add-apparmor-custom-rules
Closed

Add AppArmor custom rules#237
jorbaum wants to merge 2 commits into
cloudfoundry:mainfrom
jorbaum:add-apparmor-custom-rules

Conversation

@jorbaum

@jorbaum jorbaum commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Starting from Ubuntu Noble a new AppArmor profile for RSyslogd is used which is enforced. This might cause some access permisson problems for some plugins like imfile in Syslog. On the other hand, if someone adds some custom rules and want to include some log files which are located in directories that are not covered with the current rules, they might need a way how to extend the AppArmor rules.

This change makes this configuration possible.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests
  • Manually generated manifest and deployed on a landscape

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

chombium and others added 2 commits April 16, 2026 13:10
Starting from Ubuntu Noble a new AppArmor profile for RSyslogd is used
which is enforced. This might cause some access permisson problems for
some plugins like imfile in Syslog. On the other hand, if someone adds
some custom rules and want to include some log files which are located
in directories that are not covered with the current rules, they might
need a way how to extend the AppArmor rules.

This change makes this configuration possible.
Add documentation for the new syslog.custom_apparmor_rules property
introduced in the previous commit, covering the README and example
custom rules file.
@jorbaum
jorbaum marked this pull request as ready for review April 16, 2026 11:52
@jorbaum

jorbaum commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Also played around with acceptance tests, but I am not sure if it makes sense for this small change: jorbaum@8dbffda

@chombium chombium left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorbaum Looks good, but please fix the formatting

/var/vcap/data/syslog_forwarder/** rw,
/var/vcap/sys/log/syslog_forwarder/** rw, No newline at end of file
/var/vcap/sys/log/syslog_forwarder/** rw,
<%= p('syslog.custom_apparmor_rules') if p('syslog.custom_apparmor_rules') %>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line at the end of the file

@github-project-automation github-project-automation Bot moved this from Inbox to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Apr 20, 2026
@chombium

Copy link
Copy Markdown
Contributor

Closed in favor of #238

@chombium chombium closed this Apr 20, 2026
@github-project-automation github-project-automation Bot moved this from Waiting for Changes | Open for Contribution to Done in Foundational Infrastructure Working Group Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants