Skip to content

support pypy 3.8#454

Closed
dand-oss wants to merge 1 commit into
cloudpipe:masterfrom
dand-oss:master
Closed

support pypy 3.8#454
dand-oss wants to merge 1 commit into
cloudpipe:masterfrom
dand-oss:master

Conversation

@dand-oss

@dand-oss dand-oss commented Oct 21, 2021

Copy link
Copy Markdown

pypy 3.8 is released for download.

pypy does not supply _pickle c extension

#455

pypy 3.8 should continue to import the pure python version of pickle.
pypy 3.7 worked because of the test to import pure python pickle if python version less than 3.7.

Check for pypy platform explicitly as fix.

@jrbourbeau jrbourbeau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dand-oss -- this seems like a sensible change. There's a centralized PYPY variable already defined here

PYPY = platform.python_implementation() == "PyPy"

Would you mind using that here instead?

EDIT: In fact, it probably more sense to move the definition of the PYPY variable into the compat.py compatibility module and then import it the variable elsewhere when needed

@ogrisel

ogrisel commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

Closing in favor of #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants