fix: pass variable as a name

[mtweeman]

what

Passing variable name instead of null-label normalized ID.

why

Normalized null-label ID doesn't allow IDs including dot character. Effectively, it tries to change repository name like .github -> github.

[goruha]

@mtweeman there is variable for null-label regex_replace_chars defaults to /[^-a-zA-Z0-9]/
This is the way we should solve that problem.

Could you pls try regex_replace_chars this with /[^.-a-zA-Z0-9]/

[mtweeman]

@mtweeman there is variable for null-label regex_replace_chars defaults to /[^-a-zA-Z0-9]/ This is the way we should solve that problem.

Could you pls try regex_replace_chars this with /[^.-a-zA-Z0-9]/

@goruha, actually, I use this module via component. It passes var.repository.name. There's nothing I can do with that I guess from component side?

[goruha]

@mtweeman let's then make the fix in the component. We can set the regexp as a hardcoded value to allow dots in the name

[mtweeman]

@goruha, so this PR is fine and there should be some adjustment in the component only? Where exactly? I'm not that heavy user of null-label to know what's the best place to hard-code that.

[goruha]

@mtweeman no. We do not need the PR to solve the problem in the component.
Could you try this component version cloudposse-terraform-components/aws-github-repository#43 ?

[mtweeman]

@goruha, gotcha, I forgot that context variables can be passed from component, too.
I tested that and it still results in repository = ".github" -> "." # forces replacement
I believe that regex needs to be replaced for "/[^a-zA-Z0-9-.]/"