fix(docker): run container as non-root user#310
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
- Updates the container image definition to address a security/code-scanning finding by ensuring the Cloudsmith CLI runs as a non-root user at runtime.
Changes:
- Adds a dedicated
cloudsmithuser (uid 1000) during the image build. - Switches the runtime user to
cloudsmithbefore executing theENTRYPOINT.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cloudsmith-iduffy
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves the "Missing User Instruction" code scanning alert. The image now creates a dedicated
cloudsmithuser (uid 1000) and drops root before the entrypoint runs.Type of Change
Additional Notes
Verified locally: image builds and
cloudsmith --versionruns as uid 1000.Two remaining Dockerfile alerts are deliberately not addressed — recommend dismissal with justification: HEALTHCHECK is meaningless for a CLI entrypoint container (no long-running process), and apk version pins break rebuilds once versions rotate out of the Alpine index.