Skip to content

Use css word-wrap: break-word; where possible to break …#163

Merged
lmarini merged 2 commits into
developfrom
bugfix/filename-text-wrapping
Feb 1, 2021
Merged

Use css word-wrap: break-word; where possible to break …#163
lmarini merged 2 commits into
developfrom
bugfix/filename-text-wrapping

Conversation

@lmarini
Copy link
Copy Markdown
Member

@lmarini lmarini commented Jan 29, 2021

…words that are too long. Fixes #160.

This issue is obvious with files names that are very long.
Applied to fix to collectios, datasets, spaces titles as well where I saw an issue.
There might be more places where this could be applied.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…words that are too long.

This issue is obvious with files names that are very long.
Applied to fix to collectios, datasets, spaces titles as well where I saw an issue.
There might be more places where this could be applied.
@lmarini lmarini requested a review from a team January 29, 2021 20:07
@lmarini lmarini changed the title Fixes #160. Use css word-wrap: break-word; where possible to break … Use css word-wrap: break-word; where possible to break … Jan 29, 2021
@tcnichol
Copy link
Copy Markdown
Contributor

tcnichol commented Feb 1, 2021

Looks good. Tested space, collection, dataset and file to make sure long names wrapped correctly.

@tcnichol tcnichol self-assigned this Feb 1, 2021
Copy link
Copy Markdown
Contributor

@tcnichol tcnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All cases looked fine.

@lmarini lmarini merged commit ef63e79 into develop Feb 1, 2021
@lmarini lmarini deleted the bugfix/filename-text-wrapping branch February 1, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text wrapping for long file names

2 participants