Skip to content

Bugfix/274 cannot add dataset to space#275

Merged
max-zilla merged 3 commits into
developfrom
bugfix/274-cannot-add-dataset-to-space
Sep 28, 2021
Merged

Bugfix/274 cannot add dataset to space#275
max-zilla merged 3 commits into
developfrom
bugfix/274-cannot-add-dataset-to-space

Conversation

@tcnichol
Copy link
Copy Markdown
Contributor

Description

I found that if you went to a dataset page, if you wanted to add it to a space no spaces would be returned in the dropdown due to an error. "5" was being passed in as the date in api.spacesListCanEdit instead of the limit.

To fix I only added one extra null for the Option[Date]

Review Time Estimate

  • Immediately
  • Within one week
  • [ x] When possible

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • [x ] I have updated the CHANGELOG.md.
  • [ x] I have signed the CLA
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

the method for spaces.listCanEdit has more parameters than before, so without this, it is passing in unprarsable "5" as the data, instead of for the limit
@max-zilla max-zilla merged commit a41dc4a into develop Sep 28, 2021
@max-zilla max-zilla deleted the bugfix/274-cannot-add-dataset-to-space branch September 28, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants