Skip to content

add id in GET /metadata.jsonld responses #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmarini merged 4 commits into from
Oct 1, 2021
Merged

add id in GET /metadata.jsonld responses #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
497a654
add id
longshuicy Sep 24, 2021
8d62c68
add entry in changelog issue #278
longshuicy Sep 24, 2021
60744fd
reordering the field to make id second
longshuicy Sep 30, 2021
c040d47
Merge branch 'develop' into 278-Add-metadata-id-in-response-when-GET-…
lmarini Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Added
- Adding mime type for geojson
- Add "when" parameter in a few GET API endpoints to enable pagination [#266](https://github.com/clowder-framework/clowder/issues/266)
- Add "id" in GET metadata.jsonld endpoints [#278](https://github.com/clowder-framework/clowder/issues/278)

## 1.18.1 - 2021-08-16

Expand Down
3 changes: 2 additions & 1 deletion app/util/JSONLD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ object JSONLD {
)

//convert metadata to json using implicit writes in Metadata model
val metadataJson = resourceJson ++ toJson(metadata).asInstanceOf[JsObject]
//include metadata ID in the json
val metadataJson = JsObject(Seq("id" -> JsString(metadata.id.toString()))) ++ resourceJson ++ toJson(metadata).asInstanceOf[JsObject]

//combine the two json objects and return
if (contextJson.isEmpty) metadataJson else contextJson.get ++ metadataJson
Expand Down