Space layout with statistics#283
Merged
Merged
Conversation
- undo removal - add comment + link to issue for space stats - comment about new layout
lmarini
approved these changes
Oct 4, 2021
lmarini
added a commit
that referenced
this pull request
Oct 4, 2021
* adding parameter spaceBytes inside getSpace * add method getBytesPerSpace changing html * adding to space statistics need cleanup * statistics changed - replaced with more data modeled on the index page We now see Collections, Datasets, Files, Bytes per space and Users in right column * changelog * adding spaceBytes parameter, does not work yet * new method, get bytes for dataset * methods need to match * adding and removing datasets from space will increment spaceBytes. * increment bytes when file added to dataset * decrement space bytes on remove file * remove commented out code * use cached value of bytes per space not method call * adding update space bytes method * added space bytes update * fixig test * fix few issues with migration - no datasets in space would result in not writing out count - very large databsae would have cursor timeout - simplified logic to count bytes * Space layout with statistics (#283) * make space layout more like datasets/files * update changelog - undo removal - add comment + link to issue for space stats - comment about new layout * Lowered margin from 20px to 15px for button links. Co-authored-by: Luigi Marini <lmarini@illinois.edu> Co-authored-by: Luigi Marini <lmarini@users.noreply.github.com> Co-authored-by: Max Burnette <mburnet88@gmail.com> Co-authored-by: Rob Kooper <kooper@illinois.edu> Co-authored-by: Luigi Marini <lmarini@illinois.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes the space layout more in line with the files/datasets
NEW Layout
OLD Layout
Review Time Estimate
Types of changes
Checklist: