Skip to content

missing html closing elements#284

Merged
lmarini merged 1 commit into
developfrom
fix-folder-layout
Oct 4, 2021
Merged

missing html closing elements#284
lmarini merged 1 commit into
developfrom
fix-folder-layout

Conversation

@robkooper
Copy link
Copy Markdown
Member

Description

Listing folders in a dataset would not have folders closed correctly. This is really apparent when there are multiple folders in a dataset.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@robkooper robkooper requested a review from lmarini October 4, 2021 18:48
Copy link
Copy Markdown
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lmarini lmarini merged commit 5279445 into develop Oct 4, 2021
@lmarini lmarini deleted the fix-folder-layout branch October 4, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants