[Spec 0053] af open Image Support#103
Merged
Merged
Conversation
- Add image extension detection (png, jpg, jpeg, gif, webp, svg) - Add MIME type mapping for serving images with correct Content-Type - Add /api/image endpoint for serving raw image data - Add image viewer UI with zoom controls (Fit, 100%, +, -) - Display image dimensions and file size in header - Hide code editing UI for image files
Contributor
Author
Architect Integration Review (3-Way)Verdict: APPROVED (after spec clarification) Review Summary
Both REQUEST_CHANGES cited missing annotation system per spec. Spec has been updated (commit 9aa90aa) to clarify that annotations are intentionally not supported for images - line-based system doesn't apply. Action RequiredPlease merge this PR. The implementation is complete and correct per the updated spec. 🏗️ Architect integration review |
waleedkadous
added a commit
that referenced
this pull request
May 5, 2026
Codex review-phase REQUEST_CHANGES (HIGH): the spec's success criterion #103 ('codev init produces arch.md/lessons-learned.md') and the new arch.md template's claim ('propagates via codev init/adopt') both overstate what the framework actually does. Verified in init.ts:92-93 and adopt.ts:128: both files carry the explicit comment 'Framework files (protocols, roles, consult-types, templates) are NOT copied. They resolve at runtime from the installed npm package via the unified file resolver.' This is a deliberate foundational design decision that affects every framework template, not just arch.md/lessons-learned.md. Aligning the artifacts with reality (option chosen) rather than flipping the design decision (rejected as out of scope): - codev/templates/arch.md: 'Note on propagation' section rewritten to state honestly that init/adopt/update do NOT copy framework templates; provides a manual-copy command (require.resolve) for projects opting in. - codev-skeleton/templates/arch.md: byte-identical mirror. - codev/reviews/723-*.md: smoke-test section updated with 'Spec deviation noted' explanation; success-criteria final check updated to reference it. Gemini APPROVE and Claude APPROVE stand. Claude's two minor observations (porch artifact duplication; stale Vitest flag in approved spec) are acknowledged but not actioned as documented in the rebuttal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
af opento display images (PNG, JPG, GIF, WebP, SVG) in the dashboard viewer instead of showing binary garbage or errors.Changes
open-server.ts/api/imageendpoint for serving binary imagesFiles Changed
packages/codev/src/agent-farm/servers/open-server.tspackages/codev/templates/open.htmlcodev/reviews/0053-af-open-image-support.md3-Way Review Summary
Annotation System Discussion
The spec states "Same annotation system available (for annotating screenshots)." The implementation disables the line-based annotation UI for images because:
Codex disagrees: Argues this is a hard spec requirement that must be met.
Recommendation: If image annotation is needed, create a separate spec for coordinate-based annotation (significant new feature). The current implementation meets all other success criteria.
Test Plan
af open screenshot.pngdisplays the image/api/imageon non-image files