fix: Use pbcopy for clipboard in tmux terminals (fixes #42)#54
Merged
Conversation
OSC 52 clipboard sequences don't work reliably through the ttyd -> xterm.js -> browser chain. Changed tmux copy-mode bindings to use copy-pipe-and-cancel with pbcopy instead, which directly copies to macOS system clipboard. Changes: - dashboard-server.ts: Use pbcopy in MouseDragEnd bindings - start.ts: Add clipboard settings and pbcopy bindings - spawn.ts: Add clipboard settings and pbcopy bindings (3 locations) Also includes worktree builder improvements: - Simplified builder spawn from dashboard (no dialog, random ID) - Added spawnWorktreeBuilder function to dashboard-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy-pipe-and-cancel pbcopyinstead ofcopy-selection-and-cancelin tmux bindingsChanges
dashboard-server.ts: Use pbcopy in MouseDragEnd bindingsstart.ts: Add clipboard settings and pbcopy bindingsspawn.ts: Add clipboard settings and pbcopy bindings (3 locations)Also includes worktree builder improvements:
Test plan
Resolves #42