Conversation
kwalcock
approved these changes
Sep 15, 2023
| val (springFall, otherSeasons) = seasonMentions.partition(m => m.text.equalsIgnoreCase("spring") || m.text.equalsIgnoreCase("fall")) | ||
| val trueSeasons = springFall.filter { m => | ||
| m.tags.head.contains("NN") && { | ||
| m.tags.get.head.startsWith("NN") && { |
Member
There was a problem hiding this comment.
Thank you!
This encourages me to continue denoting Options by name (like tagsOpt) and wonder whether something like the TagSet class from Eidos should be ported. We probably shouldn't be using string operations for classifying tags.
Comment on lines
+330
to
+334
| val sd = TempEvalFormatter.mkDate(seasonNorm.get.startDay, seasonNorm.get.startMonth, yearStart) | ||
| val ed = TempEvalFormatter.mkDate(seasonNorm.get.endDay, seasonNorm.get.endMonth, yearEnd) | ||
| val dm = DateRangeMention(m, sd, ed) | ||
|
|
||
| dm |
Member
There was a problem hiding this comment.
Somebody is going to sneak in here and give these variables real names ;-)
| priority: ${ rulepriority } | ||
| type: token | ||
| pattern: | | ||
| [word=/^(1\d|2\d|3\d|4\d|5\d|6\d|7\d|8\d|9\d)$/] |
Member
There was a problem hiding this comment.
I wonder why this isn't [1-9]\d.
Contributor
Author
There was a problem hiding this comment.
Yes, it should be. It started as just [1-2] and [8-9] then I incrementally expanded without optimizing. Please adjust!
Regular expression and variable names in numeric routines
Clean up after my own complaints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.