Fix SSDP UPnP constant imports#8
Merged
Merged
Conversation
cmos486
added a commit
that referenced
this pull request
Jun 23, 2026
…ad of getSpeakerSettings (#6) outputTerminal is a sound setting (getSoundSettings v1.1), not a speaker setting. The previous code called getSpeakerSettings which returns "Illegal Argument" for this target, leaving the entity permanently unknown. Changes: - Add get_sound_settings() to BraviaClient (mirrors set_sound_settings) - Poll sound output via coordinator so external changes (TV remote, eARC) propagate automatically instead of a one-time fetch at startup - BraviaSoundOutputSelect now reads from coordinator data Also included in this release (merged from gaoflow/fix-7-ssdp-service-info-constants): - Fix SSDP UPnP constant imports (#8) Bump version to 1.5.6. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
homeassistant.helpers.service_info.ssdpSsdpServiceInfoannotation and UPnP friendly/model name lookups working on newer Home Assistant versionsATTR_UPNP_FRIENDLY_NAMEandATTR_UPNP_MODEL_NAMEonhomeassistant.components.ssdp, where current Home Assistant no longer exposes those constantsCloses #7
Verification
homeassistant.helpers.service_info.ssdpdefinesSsdpServiceInfo,ATTR_UPNP_FRIENDLY_NAME, andATTR_UPNP_MODEL_NAME;homeassistant.components.ssdponly imports the service info type.python3 -m py_compile custom_components/bravia_rest_api/config_flow.pyrg -n "from homeassistant\.components import ssdp|ATTR_UPNP|helpers\.service_info" custom_components/bravia_rest_api/config_flow.pygit diff --checkNotes
AI assistance was used under my direction.