Conversation
Draft implementation for comments Closes #35
* Fix correction config paths for editable installs * Link lwtnn-stat on MSVC builds * Added comment about editable configuration check and ran formatting * Match pre-commit import ordering in test_binding * updating spooky spaces that might be causing a problem? * Preserve correctionlib version variables across lwtnn subproject * updating version call * Update lwtnn submodule for MSVC warning flags * Point lwtnn submodule to fork for MSVC fix validation
CVMFS benchmarksTop 25 slowest-loading corrections, sorted by mean time:
|
* Accept LWTNN nodes in schema validation * Simplify tests / examples --------- Co-authored-by: Nick Smith <nick.smith@cern.ch>
nsmith-
commented
May 15, 2026
| rapidjson::Writer<rapidjson::StringBuffer> writer(buffer); | ||
| blob.Accept(writer); | ||
| std::istringstream in(buffer.GetString()); | ||
| auto cfg = lwt::parse_json(in); |
Collaborator
Author
There was a problem hiding this comment.
TODO: catch any exception here and reformat?
Collaborator
Author
There was a problem hiding this comment.
TODO: test malformed LWTNN nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft implementation for comments
Also fixes up a few bad practices in C++ (leading underscore) and starts to break out of the single file implementation a bit.
Closes #35