Refactor/oshell shellcheck fixes

[rozdolsky33]

Summary

This PR significantly refactors and enhances oshell’s OCI session authentication and management scripts, with a major focus on reliability, usability, and cross-platform compatibility. The improvements affect oci_auth_refresher.sh, oshell.sh, documentation, and usage examples.

---

Key Changes

1. Robust Session Lifecycle Management

• Consistent Logging: All profiles now log to $HOME/.oci/sessions/<profile>/oci-auth-refresher_<profile>.log instead of ~/Library/Logs.
• Refresher Process Handling: The background refresher (oci_auth_refresher.sh) is now reliably launched, tracked, and terminated per profile.
• Graceful Session Termination: ociexit [profile] terminates both the refresher process and the OCI session for the specified or current profile, with clear user feedback.
• Profile Switching: Improved support for managing multiple profiles and switching/refresher handling.

2. Improved Cross-Platform Compatibility

• Date Parsing: Added logic in oci_auth_refresher.sh to support both GNU (date -d) and BSD/macOS (date -j -f) date utilities for timestamp handling.
• Shell Compatibility: Added shellcheck directives and improved sourcing/quoting for better portability.

3. Enhanced User Experience

• Better Logging: More detailed logs for session validation, refresh attempts, errors, and session expiration.
• Informative Output: Improved CLI messages for all authentication and logout operations.
• oshell.sh Functions: Refactored functions for clarity, parameter handling, and edge-case robustness.
• Dynamic Path Handling: Paths for logs and session files are dynamically set per profile.

4. Documentation Improvements

• README.md: Expanded documentation on all lifecycle commands, session maintenance, logs, troubleshooting, and multi-profile support.
• Usage Examples: Updated example .zshrc and shell integration notes for clarity and correctness.

5. CI Improvements

• Workflow Renaming: Renamed the CI job for clarity.
• Linting: Ensured shell scripts are checked with shellcheck.
• Removed Redundant Steps: Dropped unnecessary test execution steps for .sh/.zsh files in CI.

---

How to Test

1. Authenticate with ociauth <profile> and confirm background refresher launches and logs are created.
2. Switch profiles with ociset <profile> and verify session management.
3. Logout with ociexit and ociexit <profile>; confirm both refresher and session are terminated.
4. Check logs in $HOME/.oci/sessions/<profile>/oci-auth-refresher_<profile>.log.
5. Review CLI output and ensure all commands provide clear, actionable feedback.

---

Related Issues

• Improves reliability and multi-profile support (# if any relevant issues exist)
• Addresses cross-platform compatibility
• Enhances documentation for onboarding and troubleshooting

---

Checklist

• Refresher process properly managed for each profile
• Session status and logs are consistent and accessible
• Documentation updated and expanded
• Shell scripts pass linting and CI

[dnlloyd]

The latest changes are producing a file at $HOME/.oci/sessions/oci-auth-refresher_.log which contain the checks for an existing refresh process:

Mon Jul  7 14:12:36 CDT 2025: Checking for existing refresher process for OTEST-3
Mon Jul  7 14:12:36 CDT 2025: Starting new refresher process for OTEST-3
Mon Jul  7 14:13:51 CDT 2025: Killing refresher process for profile OTEST-3
Mon Jul  7 14:20:09 CDT 2025: Checking for existing refresher process for OTEST-4
Mon Jul  7 14:20:09 CDT 2025: Starting new refresher process for OTEST-4

[rozdolsky33]

Here is my output: