changefeedccl: support CREATE DATABASE CHANGEFEED syntax#147663
Merged
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
4 times, most recently
from
4c2fe54 to
70fdd23
Compare
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
5 times, most recently
from
33e9efd to
cd1f7a0
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
7 times, most recently
from
522faa9 to
46950b5
Compare
KeithCh
commented
Jun 4, 2025
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
from
46950b5 to
f048762
Compare
KeithCh
requested review from
a team,
andyyang890 and
asg0451
and removed request for
a team
KeithCh
changed the title
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
2 times, most recently
from
3b75ceb to
350ed98
Compare
msbutler
reviewed
Jun 12, 2025
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
2 times, most recently
from
69f4ea0 to
f0bb57f
Compare
asg0451
suggested changes
Jun 24, 2025
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
8 times, most recently
from
3d40746 to
de58985
Compare
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
2 times, most recently
from
3ad34aa to
2d99947
Compare
asg0451
approved these changes
Jul 1, 2025
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
from
2d99947 to
6bb5a2b
Compare
Add basic syntax support for database-level changefeeds. CREATE DATABASE CHANGEFEED for foo This PR only allows the aforementioned statement to be parsed; no changefeed is created. Epic: CRDB-1421 Resolves: cockroachdb#147369 Release note: None
KeithCh
force-pushed
the
db-level-changefeed-parser
branch
from
6bb5a2b to
8c91603
Compare
Contributor
Author
|
bors r=asg0451 tftr! |
Contributor
|
Build succeeded: |
celeste-cockroachdb
Bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic syntax support for database-level
changefeeds.
CREATE DATABASE CHANGEFEED for fooThis PR only allows the aforementioned statement
to be parsed; no changefeed is created.
Epic: CRDB-1421
Resolves: #147369
Release note: None